Verify compatibility with K2 mode for Kotlin-dependent plugins #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novotnyr
requested review from
YannCebron,
kesarevs,
chrkv and
LChernigovskaya
novotnyr
changed the title
YannCebron
reviewed
Sep 11, 2024
...e/structure-intellij/src/main/java/com/jetbrains/plugin/structure/intellij/plugin/IdeMode.kt
Outdated
Show resolved
Hide resolved
...ure-intellij/src/main/java/com/jetbrains/plugin/structure/intellij/problems/MinorWarnings.kt
Outdated
Show resolved
Hide resolved
...ure-intellij/src/main/java/com/jetbrains/plugin/structure/intellij/problems/MinorWarnings.kt
Show resolved
Hide resolved
...ure-intellij/src/main/java/com/jetbrains/plugin/structure/intellij/problems/MinorWarnings.kt
Outdated
Show resolved
Hide resolved
.../com/jetbrains/pluginverifier/results/problems/UndeclaredKotlinK2CompatibilityModeProblem.kt
Outdated
Show resolved
Hide resolved
YannCebron
approved these changes
Sep 11, 2024
...re-intellij/src/main/java/com/jetbrains/plugin/structure/intellij/plugin/KotlinPluginMode.kt
Outdated
Show resolved
Hide resolved
...ugin-verifier/verifier-intellij/src/main/java/com/jetbrains/pluginverifier/PluginVerifier.kt
Show resolved
Hide resolved
YannCebron
reviewed
Sep 17, 2024
...ij/src/main/java/com/jetbrains/plugin/structure/intellij/problems/InvalidDescriptorErrors.kt
Outdated
Show resolved
Hide resolved
LChernigovskaya
approved these changes
Sep 17, 2024
novotnyr
force-pushed
the
mp-6825-declare-compatibility-with-k2-mode
branch
from
470e660
to
42952c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin that depends on the Kotlin plugin and does not declare compatibility will emit a Compatibility Problem.
KotlinPluginModeproperty in plugins that indicates the K1/K2 compatibility level. UseImplicitfor missing value in existing plugins. UseInvalidfor plugins that declare no compatibility with both K1 and K2 compatibility levels.UndeclaredKotlinK2CompatibilityModeplugin problem with Warning level for any plugin. The actual plugin problem severity depends on the Platform version:CompatibilityProblemreported by the Plugin Verifier. More specifically, it is an instance ofUndeclaredKotlinK2CompatibilityModeProblemin the Plugin Verifier.KotlinCompatibilityModeProblemResolverclass. Thestructurelibrary is unaware of the IDE version, hence the decision is deferred to the Plugin Verifier.KotlinCompatibilityModeProblemResolverwill remove all instances ofUndeclaredKotlinK2CompatibilityModeplugin structure warnings after remapping, as not to cause duplicate compatibility problems.InvalidKotlinPluginModeplugin problem with Error level for any plugin. This happens when bothsupportsK1andsupportsK2are set tofalse.See MP-6825