BSP import: don't add Scala library to runtime classpath in Scala SDK #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing a project through bsp, the compiler classpath
(scala-library, scala-reflect, scala-compiler) obtained through
bsp should only be used for the "Compiler classpath" section of the
Scala SDK.
Before this change, the classpath was also added to the module's
`<CLASSES>` ("Standard library" section of the Scala SDK in the UI).
This is
- slightly incorrect, because it adds the scala-compiler jar to the
module's classpath
- not needed, because the scala-library is added to the module's
classpath as a separate library
scala/scala-dev#786 (comment)
jastice
approved these changes
Sep 17, 2021
|
Merging was causing troubles so I applied this change manually. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a project through bsp, the compiler classpath
(scala-library, scala-reflect, scala-compiler) obtained through
bsp should only be used for the "Compiler classpath" section of the
Scala SDK.
Before this change, the classpath was also added to the module's
<CLASSES>("Standard library" section of the Scala SDK in the UI).This is
module's classpath
classpath as a separate library
scala/scala-dev#786 (comment)