-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new Swing interop page #231
base: master
Are you sure you want to change the base?
Conversation
ElviraMustafina
commented
Sep 16, 2024
- new page for Swing interop
- new gifs
- minor updates to code samples: added titles for windows, removed unused imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also document our new flags:
compose.swing.render.on.graphics
compose.layers.type
compose.interop.blending
> | ||
{style="warning"} | ||
|
||
To enable this experimental feature, use the `compose.interop.blending` system property: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please copy a note about "The property must be set before executing any Compose code in your application" here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatkovIvan Should we also recommend to set it via the command line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I think we could make the purpose of the article a bit clearer, left some suggestions about that.
|
||
To enable this experimental feature, set the `compose.interop.blending` system property to `true`. | ||
The property must be set before executing any Compose code in your application, | ||
so use `System.setProperty()` at the entry point: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier we recommend using a command-line argument in the same kind of situation for compose.swing.render.on.graphics
, is that not the case here?