Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new Swing interop page #231

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ElviraMustafina
Copy link
Collaborator

  • new page for Swing interop
  • new gifs
  • minor updates to code samples: added titles for windows, removed unused imports

Copy link
Member

@m-sasha m-sasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also document our new flags:

  • compose.swing.render.on.graphics
  • compose.layers.type
  • compose.interop.blending

topics/compose/compose-desktop-swing-interoperability.md Outdated Show resolved Hide resolved
topics/compose/compose-desktop-swing-interoperability.md Outdated Show resolved Hide resolved
@m-sasha m-sasha requested review from MatkovIvan and removed request for igordmn October 8, 2024 10:15
>
{style="warning"}

To enable this experimental feature, use the `compose.interop.blending` system property:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please copy a note about "The property must be set before executing any Compose code in your application" here too

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatkovIvan Should we also recommend to set it via the command line?

Copy link
Collaborator

@zamulla zamulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I think we could make the purpose of the article a bit clearer, left some suggestions about that.

topics/compose/compose-desktop-swing-interoperability.md Outdated Show resolved Hide resolved
topics/compose/compose-desktop-swing-interoperability.md Outdated Show resolved Hide resolved
topics/compose/compose-desktop-swing-interoperability.md Outdated Show resolved Hide resolved
topics/compose/compose-desktop-swing-interoperability.md Outdated Show resolved Hide resolved
topics/compose/compose-desktop-swing-interoperability.md Outdated Show resolved Hide resolved
topics/compose/compose-desktop-swing-interoperability.md Outdated Show resolved Hide resolved

To enable this experimental feature, set the `compose.interop.blending` system property to `true`.
The property must be set before executing any Compose code in your application,
so use `System.setProperty()` at the entry point:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier we recommend using a command-line argument in the same kind of situation for compose.swing.render.on.graphics, is that not the case here?

topics/compose/compose-desktop-swing-interoperability.md Outdated Show resolved Hide resolved
topics/compose/compose-desktop-swing-interoperability.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants