Memory leak checker API. #3368
Memory leak checker API. #3368
Conversation
olonho
force-pushed
the
leaks_no_crash
branch
from
d8fdbc7 to
e840058
Compare
| /** | ||
| * If the memory leak checker is activated, by default true in debug mode, false in release. | ||
| * When memory leak checker is activated, and leak detected on process termination process | ||
| * is terminated with non-zero exit code. |
There was a problem hiding this comment.
Oh, forgot to push update doc.
There was a problem hiding this comment.
Error message without termination is somewhat undiscoverable (including leaks in Kotlin/Native tests). Why not terminate?
There was a problem hiding this comment.
Well, OK, will update message as well.
| * When memory leak checker is activated, and leak detected on process termination process | ||
| * is terminated with non-zero exit code. | ||
| */ | ||
| public var hasMemoryLeakChecker: Boolean |
There was a problem hiding this comment.
The name doesn't correspond to the behaviour.
Maybe isMemoryLeakCheckerEnabled?
| * is terminated with non-zero exit code. | ||
| * If the memory leak checker is activated, by default `true` in debug mode, `false` in release. | ||
| * When memory leak checker is activated, and leak is detected during last Kotlin/Native runtime | ||
| * deinitialization process - error message with leak information is printed. |
There was a problem hiding this comment.
during last Kotlin/Native runtime deinitialization process
This is unclear. Maybe align the terms with workers?
There was a problem hiding this comment.
What would you suggest?
There was a problem hiding this comment.
Workers seem to use "Kotlin context":
I suggest using the same phrase here, maybe described more verbosely (like "workers and platform threads ran Kotlin code"). Or maybe keep only the description, without "Kotlin context".
olonho
force-pushed
the
leaks_no_crash
branch
from
a0a16d4 to
8b0235f
Compare
No description provided.