This repository has been archived by the owner on Aug 10, 2021. It is now read-only.
Fix interop declarations generation #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9c1fc56
homuroll
reviewed
Dec 3, 2020
| symbol = symbolTable.referenceConstructor(enumDescriptor.unsubstitutedPrimaryConstructor!!), | ||
| typeArgumentsCount = 0 // enums can't be generic | ||
| symbol = constructorSymbol, | ||
| typeArgumentsCount = constructorSymbol.owner.typeParameters.size, |
There was a problem hiding this comment.
Constructors can't have any type parameters unless they are declared in Java which is impossible on Native.
| @@ -80,7 +81,8 @@ internal class CEnumClassGenerator( | |||
| createEnumEntry(descriptor, entryDescriptor) | |||
| } | |||
| enumClassMembersGenerator.generateSpecialMembers(enumIrClass) | |||
| enumIrClass.addChild(cEnumCompanionGenerator.generate(enumIrClass)) | |||
| enumIrClass.addChild(cEnumCompanionGenerator. | |||
| generate(enumIrClass)) | |||
There was a problem hiding this comment.
Minor. Coding style is a bit broken
LepilkinaElena
approved these changes
Dec 3, 2020
homuroll
approved these changes
Dec 3, 2020
Current approach to generate interop enum and structs during linkage stage turned out to be fragile. We might get unbound wrapper descriptors which are useless for function body generation. The solution is to postpone body generation until linkage step is complete.
sbogolepov
force-pushed
the
sbogolepov/fix-wrapped-discroptors
branch
from
f9a15fc to
a965235
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.