Skip to content

Commit

Permalink
[Wasm] Add ticket comments to the known problems
Browse files Browse the repository at this point in the history
  • Loading branch information
igoriakovlev authored and qodana-bot committed Sep 21, 2024
1 parent 4655a7e commit dc81f28
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ internal class JsIrLinkerLoader(
val modifiedStrategy = when {
loadAllIr -> DeserializationStrategy.ALL
module == mainLibrary -> DeserializationStrategy.ALL
loadKotlinTest && descriptor.name.asString() == "<kotlin-test>" -> DeserializationStrategy.ALL
loadKotlinTest && descriptor.name.asString() == "<kotlin-test>" -> DeserializationStrategy.ALL //KT-71037
else -> DeserializationStrategy.EXPLICITLY_EXPORTED
}
val modified = modifiedFiles[libraryFile]?.keys?.mapTo(hashSetOf()) { it.path } ?: emptySet()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ open class WasmCompilerWithIC(
val irBuiltIns = mainModule.irBuiltins
val symbolTable = (irBuiltIns as IrBuiltInsOverDescriptors).symbolTable

//Hack - pre-load functional interfaces in case if IrLoader cut its count
//Hack - pre-load functional interfaces in case if IrLoader cut its count (KT-71039)
repeat(25) {
mainModule.irBuiltins.functionN(it)
mainModule.irBuiltins.suspendFunctionN(it)
Expand Down Expand Up @@ -76,6 +76,8 @@ open class WasmCompilerWithIC(
lowerings.enabled.addAll(wasmPhases.toPhaseMap().values)
}.build()

//TODO: Lower only needed files but not all loaded by IrLoader KT-71041

lowerPreservingTags(
allModules,
context,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ class WasmCompiledModuleFragment(
}

fun linkWasmCompiledFragments(): WasmModule {
// TODO: Implement optimal ir linkage KT-71040
bindUnboundSymbols()
addCompileTimePerClassData()
handleExports()
Expand Down

0 comments on commit dc81f28

Please sign in to comment.