Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertSame and assertNotSame methods. #1230

Closed
wants to merge 1 commit into from
Closed

Add assertSame and assertNotSame methods. #1230

wants to merge 1 commit into from

Conversation

JakeWharton
Copy link
Contributor

No description provided.

@JakeWharton
Copy link
Contributor Author

@ilya-g

@JakeWharton JakeWharton force-pushed the jw/2017-08-04/same branch 2 times, most recently from fdb0d01 to 793e9f1 Compare August 5, 2017 01:36
piotrek1543
piotrek1543 reviewed Aug 8, 2017
View reviewed changes
libraries/kotlin.test/common/src/test/kotlin/kotlin/test/tests/BasicAssertionsTest.kt
@@ -10,6 +10,12 @@ class BasicAssertionsTest {
}

@Test
fun testAssertSame() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test prefix reminds me old days of JUnit, where it was obligatory to run any test :-)

Could you tell me why there is doubled kotlin and test packages in path: kotlin/libraries/kotlin.test/common/src/test/kotlin/kotlin/test/tests/? Just wondering.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kotlin.test/common is the project directory, then src/test/kotlin is the source root for tests, then kotlin/test/tests is the package name for tests of kotlin.test :)

@ilya-g
Copy link
Member

ilya-g commented Oct 14, 2017

I've merged it with minor edits: 485ca10~2...485ca10

@ilya-g ilya-g closed this Oct 14, 2017
@JakeWharton
Copy link
Contributor Author

JakeWharton commented Oct 14, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-g ilya-g ilya-g left review comments

@piotrek1543 piotrek1543 piotrek1543 left review comments

Assignees

@ilya-g ilya-g

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeWharton @ilya-g @piotrek1543