Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add injected Logger #286

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Add injected Logger #286

merged 2 commits into from
Feb 28, 2025

Conversation

zsmb13
Copy link
Contributor

@zsmb13 zsmb13 commented Feb 26, 2025 •
edited
Loading

Fixes #285

@zsmb13 zsmb13 force-pushed the feature/logging branch 2 times, most recently from 96a3932 to d398059 Compare February 26, 2025 15:21
@zsmb13 zsmb13 changed the title Feature/logging Add injected Logger Feb 26, 2025
@zsmb13 zsmb13 mentioned this pull request Feb 26, 2025
Merged
Base automatically changed from feature/permissions to kotlinconf-2025 February 28, 2025 09:47
@zsmb13 zsmb13 requested review from kropp and e5l February 28, 2025 10:59
@zsmb13 zsmb13 marked this pull request as ready for review February 28, 2025 10:59
e5l
e5l approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we try Kermit https://github.com/touchlab/Kermit?

@zsmb13
Copy link
Contributor Author

zsmb13 commented Feb 28, 2025

I'll add an issue to try Kermit later

@zsmb13 zsmb13 merged commit f3b3da8 into kotlinconf-2025 Feb 28, 2025
5 checks passed
@zsmb13 zsmb13 deleted the feature/logging branch February 28, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kropp kropp kropp approved these changes

@e5l e5l e5l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zsmb13 @kropp @e5l