Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added simdjson stubs. #1592

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Added simdjson stubs. #1592

merged 3 commits into from
Dec 1, 2023

Conversation

bartvanhoutte
Copy link
Contributor

Added stubs for https://github.com/crazyxman/simdjson_php.

CS is ok, unsure if I need to do anything else.

@isfedorov
Copy link
Contributor

isfedorov commented Nov 30, 2023 •
edited
Loading

@bartvanhoutte Could you please update stubs map with command docker-compose -f docker-compose.yml run test_runner /usr/local/bin/php tests/Tools/generate-stub-map and also add extension to the \StubTests\TestData\Providers\Stubs\PhpCoreStubsProvider::$StubDirectoryMap under PECL group

@isfedorov isfedorov merged commit 1858014 into JetBrains:master Dec 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartvanhoutte @isfedorov