Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brotli extension support #1632

Merged
merged 6 commits into from
Apr 17, 2024
Merged

Brotli extension support #1632

merged 6 commits into from
Apr 17, 2024

Conversation

Simbiat
Copy link
Contributor

@Simbiat Simbiat commented Apr 10, 2024

Stub for Brotli extension https://pecl.php.net/package/brotli, https://github.com/kjdev/php-ext-brotli
First time doing this, so hope everything is correct. Extension also has steam prefix compress.brotli and OB handler ob_brotli_handler, but I am unsure how to add them, if they can/should be added even. I am also not entirely sure about values for constants besides compression, since I do not see them in the extension's code itself, so I took them from https://brotli.org/encode.html and https://rcos.io/static/internal_docs/brotli_sys/index.html under assumption, that they would be the same.

@isfedorov
Copy link
Contributor

@Simbiat Could you please update stubs map https://github.com/JetBrains/phpstorm-stubs?tab=readme-ov-file#how-to-update-stub-map and add appropriate folder name to \StubTests\TestData\Providers\Stubs\PhpCoreStubsProvider::$StubDirectoryMap under 'PECL' array? thank you!

@Simbiat
Copy link
Contributor Author

Simbiat commented Apr 10, 2024

What if I do not have docker? Or PHPUnit, for that matter, which is required for running tests. For the map, can I just run tests/Tools/generate-stub-map script using my local build of PHP?

@isfedorov
Copy link
Contributor

For the map, can I just run tests/Tools/generate-stub-map script using my local build of PHP?

Yes, generally you can run scripts using local interpreter as well

@Simbiat
Copy link
Contributor Author

Simbiat commented Apr 14, 2024

Added updated map along with minor fixes for types

@isfedorov isfedorov merged commit fb7e859 into JetBrains:master Apr 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants