-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't depend on kotlinx-coroutines-swing #515
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
skiko/src/awtMain/kotlin/org/jetbrains/skiko/MainUIDispatcher.awt.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
package org.jetbrains.skiko | ||
|
||
import kotlinx.coroutines.* | ||
import java.awt.event.ActionListener | ||
import java.lang.Runnable | ||
import java.util.concurrent.TimeUnit | ||
import javax.swing.SwingUtilities | ||
import javax.swing.Timer | ||
import kotlin.coroutines.CoroutineContext | ||
|
||
/** | ||
* Dispatcher for UI thread, which is used in the current implementation of native UI integration. | ||
* Currently, it uses Swing event dispatching thread. | ||
*/ | ||
val MainUIDispatcher: CoroutineDispatcher | ||
get() = SwingDispatcher | ||
|
||
/** | ||
* Dispatcher for Swing event dispatching thread. | ||
* | ||
* Copy of Dispatchers.Swing from kotlinx-coroutines-swing. | ||
* | ||
* We don't depend on kotlinx-coroutines-swing, because it will override Dispatchers.Main, and | ||
* application can require a different Dispatchers.Main. | ||
* | ||
* Note, that we use internal API `Delay` and experimental `resumeUndispatched`. | ||
* That means it can be changed in the future. When it happens, we need | ||
* to release a new version of Skiko. | ||
*/ | ||
@OptIn(InternalCoroutinesApi::class, ExperimentalCoroutinesApi::class) | ||
private object SwingDispatcher : CoroutineDispatcher(), Delay { | ||
override fun dispatch(context: CoroutineContext, block: Runnable): Unit = SwingUtilities.invokeLater(block) | ||
|
||
override fun scheduleResumeAfterDelay(timeMillis: Long, continuation: CancellableContinuation<Unit>) { | ||
val timer = schedule(timeMillis, TimeUnit.MILLISECONDS) { | ||
with(continuation) { resumeUndispatched(Unit) } | ||
} | ||
continuation.invokeOnCancellation { timer.stop() } | ||
} | ||
|
||
override fun invokeOnTimeout(timeMillis: Long, block: Runnable, context: CoroutineContext): DisposableHandle { | ||
val timer = schedule(timeMillis, TimeUnit.MILLISECONDS) { | ||
block.run() | ||
} | ||
return object : DisposableHandle { | ||
override fun dispose() { | ||
timer.stop() | ||
} | ||
} | ||
} | ||
|
||
private fun schedule(time: Long, unit: TimeUnit, action: ActionListener): Timer = | ||
Timer(unit.toMillis(time).coerceAtMost(Int.MAX_VALUE.toLong()).toInt(), action).apply { | ||
isRepeats = false | ||
start() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 0 additions & 8 deletions
8
skiko/src/awtMain/kotlin/org/jetbrains/skiko/redrawer/MainUIDispatcher.awt.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we rename
MainUIDispatcher
toDispatchers.SkikoUI
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's hard question, as
Dispatchers.XXX
assumes that it's part of coroutines library. Guess we'd better keep as is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok