Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub Actions Linux mavenLocal test with Android step #655

Merged
merged 8 commits into from
Jan 30, 2023
Merged

Fix GitHub Actions Linux mavenLocal test with Android step #655

merged 8 commits into from
Jan 30, 2023

Conversation

dima-avdeev-jb
Copy link
Contributor

CI was failed on platform name "android-33-ext4". Because of "33-ext4" fails to cast toInt(). Now it is fixed.

AlexeyTsvetkov
AlexeyTsvetkov approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@AlexeyTsvetkov AlexeyTsvetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name.removePrefix("android-").removeSuffix("-ext4").toInt() would look simpler to me, but I don't mind the proposed version too

@dima-avdeev-jb dima-avdeev-jb merged commit 1e9c186 into master Jan 30, 2023
@dima-avdeev-jb dima-avdeev-jb deleted the dima-avdeev/fix-ci-github-actions-android branch January 30, 2023 15:47
@dima-avdeev-jb dima-avdeev-jb mentioned this pull request Feb 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyTsvetkov AlexeyTsvetkov AlexeyTsvetkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dima-avdeev-jb @AlexeyTsvetkov