Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #201

Merged
merged 3 commits into from
Feb 15, 2019
Merged

Fix build #201

merged 3 commits into from
Feb 15, 2019

Conversation

sambrightman
Copy link
Contributor

Taking the view that it's better to first get the build green and then
add support for new versions.

@sambrightman
Copy link
Contributor Author

The Travis error looks like a transient network error that will succeed when retried. I did not look much at AppVeyor - it can't find pywin32>=223 but it exists https://pypi.org/project/pywin32/#history.

@sambrightman
Copy link
Contributor Author

Hmm, there are no wheels for 3.4. Not sure if they dropped support and what you want to do about that. Still, this fixes the Travis build.

@sambrightman
Copy link
Contributor Author

sambrightman commented Feb 12, 2019

I added a workaround for Python 3.4 on Windows even though it's EOL soon. Python 2.7 may still fail due to pytest-dev/pytest#4770 coming up in the last few hours.

@sambrightman
Copy link
Contributor Author

All tests should now pass (on re-run of AppVeyor/Python 2.7)

@sambrightman sambrightman mentioned this pull request Feb 15, 2019
@shalupov shalupov merged commit 967915b into JetBrains:master Feb 15, 2019
@shalupov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants