Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to build asar package #29

Closed
LiveEmily opened this issue Sep 11, 2022 · 10 comments
Closed

failed to build asar package #29

LiveEmily opened this issue Sep 11, 2022 · 10 comments
Labels
bug Something isn't working

Comments

@LiveEmily
Copy link

Environment

  • OS: Arch Linux
  • nody-greeter version: 1.5.1

Bug description

When trying to build, packaging the asar throws an error having to do with python.

Steps to reproduce

Clone the repo recursively, install npm dependencies, run rebuild, run build.

Expected behavior

Package should build successfully so you can continue with installing

Screenshots

image

@LiveEmily LiveEmily added the bug Something isn't working label Sep 11, 2022
@JezerM
Copy link
Owner

JezerM commented Sep 16, 2022

Seems to be an upstream error about node-gyp-bins. I'll look for a solution soon~

@cy1der
Copy link

cy1der commented Sep 24, 2022

Any fix yet?

@JezerM
Copy link
Owner

JezerM commented Sep 24, 2022

No, sorry, I haven't had time to see through this error. Also, it seems there is a PR trying to solve it in nody-gyp, but it hasn't been completed nor merged yet.

@sachin746
Copy link

just trying to install this greeter same error
image

JezerM added a commit that referenced this issue Dec 22, 2022
@JezerM
Copy link
Owner

JezerM commented Dec 22, 2022

Well, I fixed this issue by patching the asar package. This isn't ideal, and it's not the best way to do it as it should've been done in the node-gyp package, but it works. Tell me if it works~

Use the master branch and build nody-greeter again. Also, sorry for the late fix, I was very busy these 3 months xd

@cy1der
Copy link

cy1der commented Dec 22, 2022

Thanks, I will test it later today. Also, does this greeter work with themes for WebKit?

@cy1der
Copy link

cy1der commented Dec 22, 2022

Now I'm unable to run npm install.
2022-12-22T15_15_16_526Z-debug-0.log
Latest node, npm and node-gyp version

@JezerM
Copy link
Owner

JezerM commented Dec 22, 2022

@cy1der, nodejs v19 is not supported by node-gtk yet, as stated in their README:

Supported Node.js versions: 14, 16, 17, 18 (other versions should work but are untested)

So, I'd recommend you to use an older version of nodejs.

@cy1der
Copy link

cy1der commented Dec 22, 2022

How to switch to older version?

@JezerM
Copy link
Owner

JezerM commented Dec 22, 2022

Well, it depends on your package management system. If using ArchLinux, install the nodejs-lts-hydrogen package, which is nodejs v18.

@JezerM JezerM closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants