add npm run actions, remove github: prefix, ios-deploy optionalDependency

[daniellacosse]

server: Jigsaw-Code/outline-server#993

[daniellacosse]

ah @fortuna this is the crux of the version mismatch:

So when I accidentally ran yarn in this project, electron-builder complained - but then I remembered we were supposed to use npm and I started fresh and it worked. Kept it at v12, However in the CI it explicitly asks for v14. I have two ways to proceed:

1. upgrade outline-server to v14 and see what happens
2. provide an .nvmrc and instructions for switching versions across the different projects via nvm use

I'm gonna try #1 first - I guess I'll just run a bunch of the actions and see if anything comes up? From what I've seen so far our testing strategy seems uneven.

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: undefined,
npm WARN EBADENGINE   required: { node: '^12', npm: '^6' },
npm WARN EBADENGINE   current: { node: 'v12.22.6', npm: '7.24.1' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'app-builder-lib@22.11.7',
npm WARN EBADENGINE   required: { node: '>=14.0.0' },
npm WARN EBADENGINE   current: { node: 'v12.22.6', npm: '7.24.1' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'electron-builder@22.11.7',
npm WARN EBADENGINE   required: { node: '>=14.0.0' },
npm WARN EBADENGINE   current: { node: 'v12.22.6', npm: '7.24.1' }
npm WARN EBADENGINE }

[fortuna]

Revert. This is a transitive dependency, I believe.

[daniellacosse]

It doesn't work for me, if i revert it

[daniellacosse]

#1081 (comment)

[daniellacosse]

What version of NPM should I be using? Wonder if this is causing it, and the issue here

Screen.Recording.2021-09-29.at.4.00.28.PM.mov

[daniellacosse]

NPM V7 seems to have fixed the github: thing i was seeing, but it still won't build unless i explicitly add ios-deploy - either globally or this way

[daniellacosse]

found it - this happens when you have xcode open or your iphone connected to your mac apache/cordova-ios#420

[daniellacosse]

using optionalDependencies seems to be the solution - linux ignores it on failure, but it's installed locally on mac in case the dev has their phone plugged in