➖ fix(deps): statically link vcruntime140.dll into smartdnsblock.exe #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
changed the title
fortuna
approved these changes
Jan 27, 2022
Good suggestion, I added |
jyyi1
force-pushed
the
junyi/use-static-vcruntime
branch
from
170a6ce to
9aa5e6d
Compare
fortuna
requested changes
Jan 28, 2022
tools/smartdnsblock/devdoc.md
Outdated
| @@ -0,0 +1,22 @@ | |||
| # `smartdnsblock` | |||
There was a problem hiding this comment.
Let's rename it to README.md so it shows up on the Github UI.
There was a problem hiding this comment.
😄 I did that as well but forgot to push.
fortuna
approved these changes
Jan 29, 2022
tools/smartdnsblock/devdoc.md
Outdated
| @@ -0,0 +1,22 @@ | |||
| # `smartdnsblock` | |||
…w-Code/outline-client into junyi/use-static-vcruntime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
smartdnsblock.exedepends onVCRUNTIME140.dllwhich was not included in the electron installer, therefore some users might not be able to connect to a VPN server if they did not install any VC runtimes before. (following is the binary dump for the previoussmartdnsblock.exe)In this PR, I statically linked the VC runtime library into the
smartdnsblock.exeitself. So the binary size increases a lot, but now the dependencies are much simpler:Note the
smartdnsblock.exeis currently a released version in x86 instead of a x64.Fixes #1130