🚑️ hotfix(electron): fix cordova ReferenceError in electron #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
changed the title
fortuna
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I fixed an issue found during the v1.7.0 release:
Uncaught ReferenceError: cordova is not defined. This is because we are referencing a non-exist global variable incordova?.platformId ?? 'Electron'. We can use aglobalorwindowsprefix likeglobal.cordova?.platformId, but that might not work well either in electron or browser. Therefore, I chose to use a more traditional way of determining whether a global variable exists:typeof cordova === 'undefined'.BTW, I also fixed the start action script, it was passing the wrong arguments to
buildaction.