Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cordova-osx #852

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Update cordova-osx #852

merged 3 commits into from
Sep 10, 2020

Conversation

alalamav
Copy link
Contributor

@alalamav alalamav commented Sep 10, 2020

  • Updates cordova-osx to v6.0.0.
    • Unlike cordova-ios, cordova-osx still uses WebView, so local storage migration is not necessary.
  • Version-controls macOS plugin configuration files as a workround for a failure to restore plugins from package.json.
    • Reproduced this issue in a minimal macOS project; manually adding plugins results in the expected configuration.
    • I'm not yet sure if this is an issue with cordova-osx, cordova-cli or one of its dependencies, i.e. cordova-common, cordova-lib (note that all these had breaking updates).
  • Minor iOS compatibility fixes.

@alalamav alalamav requested a review from fortuna September 10, 2020 02:04
@alalamav alalamav self-assigned this Sep 10, 2020
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand. Do you get different configuration files when you add the plugins from the package.json? Adding manually works, but automatically gets you an error?

Perhaps we need a comment somewhere explaining how to revert when things are working.

@@ -0,0 +1,44 @@
cordova.define('cordova/plugin_list', function(require, exports, module) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment explaining why this was added and what needs to be done to clean up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to get your thoughts about where to add the comment. I was thinking of adding to package.json for visibility.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json sounds good to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in afd52c8.

@alalamav
Copy link
Contributor Author

Do you get different configuration files when you add the plugins from the package.json?

Yes, it seems like instead of adding all plugins to the config files (cordova_plugins.js, osx.json, config.xml), only the last installed plugin overrides the config.

Adding manually works, but automatically gets you an error?

Restoring from package.json (automatically) fails. The committed config files result from manually removing and adding each plugin.

@alalamav
Copy link
Contributor Author

Reported the issue at apache/cordova-osx#106.

@alalamav alalamav merged commit c7697b4 into alalama-cordova-updates Sep 10, 2020
@alalamav alalamav mentioned this pull request Sep 10, 2020
alalamav added a commit that referenced this pull request Sep 14, 2020
- Update cordova-cli@10.0.0 (#846)
- Update cordova-ios@6.1.1 (#846)
- Update cordova-osx@6.0.0 (#852)
- Update cordova-android@9.0.0 (#853)
- Update android build docker image (#855)
@fortuna fortuna deleted the cordova-osx-6 branch July 21, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants