-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cordova-osx #852
Update cordova-osx #852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand. Do you get different configuration files when you add the plugins from the package.json? Adding manually works, but automatically gets you an error?
Perhaps we need a comment somewhere explaining how to revert when things are working.
@@ -0,0 +1,44 @@ | |||
cordova.define('cordova/plugin_list', function(require, exports, module) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment explaining why this was added and what needs to be done to clean up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to get your thoughts about where to add the comment. I was thinking of adding to package.json
for visibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json sounds good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in afd52c8.
Yes, it seems like instead of adding all plugins to the config files (
Restoring from |
Reported the issue at apache/cordova-osx#106. |
package.json
.