This repository has been archived by the owner on May 6, 2024. It is now read-only.
Make errors an enum type #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
I like it. The code LGTM. But I'm thinking of a more standard way of defining custom errors in Go, and how can we leverage standard errors package. For example, syscall.Errno We may refactor it later.
| @@ -48,7 +48,7 @@ type reachabilityError struct { | |||
| // the current network. Parallelizes the execution of TCP and UDP checks, selects the appropriate | |||
| // error code to return accounting for transient network failures. | |||
| // Returns an error if an unexpected error ocurrs. | |||
| func CheckConnectivity(client *outline.Client) (int, error) { | |||
| func CheckConnectivity(client *outline.Client) (neterrors.Error, error) { | |||
There was a problem hiding this comment.
I think we can just return error, and use errors.Is to determine whether it is our neterrors.Error object.
There was a problem hiding this comment.
I agree!
Using error unwrapping would be much cleaner, but that would break the existing API, so I left it as is for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a better way to do enums in Go.
The way we do errors in this API is still problematic, but at least this is a bit better.