Skip to content

Commit

Permalink
update readme and app path
Browse files Browse the repository at this point in the history
  • Loading branch information
daniellacosse committed Sep 29, 2023
1 parent 000808a commit ddd6116
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 18 deletions.
12 changes: 5 additions & 7 deletions x/examples/outline-connectivity-app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,8 @@ export class AppMain extends LitElement {
- [Yarn](https://yarnpkg.com/)
- Golang
- [Go](https://golang.org/)
- `PATH=$PATH:$(go env GOPATH)/bin`
- [Wails](https://wails.app/)
- [Gomobile](https://pkg.go.dev/golang.org/x/mobile/cmd/gomobile)
- `gomobile init`
- [Gomobile](../../mobileproxy/README.md#build-the-ios-and-android-libraries-with-gomobile-bind)
- Apple
- [Xcode](https://developer.apple.com/xcode/)
- [CocoaPods](https://cocoapods.org/)
Expand Down Expand Up @@ -123,15 +121,15 @@ If at any point you run into issues during development, try `yarn reset`.

### Needed Improvements

1. **\[P1\]** platform-specific styles
1. **\[P1\]** android-specific CSS
1. **\[P1\]** read browser language on load, centralize language list, and only localize once
1. **\[P1\]** documentation on how to generate mobile app build credentials
1. **\[P1\]** add individual test result errors to the test result output UI
1. **\[P2\]** use x/config to parse the access key and showcase the different transports (see: https://github.com/Jigsaw-Code/outline-sdk/blob/main/x/examples/outline-connectivity/main.go)
1. **\[P2\]** generalize request handler via generics/reflection
1. **\[P2\]** Create a logo for the app
1. **\[P2\]** Make backend request calls non-blocking
1. **\[P2\]** Introducing some kind of tracing into the test
1. **\[P2\]** create a logo for the app
1. **\[P2\]** make backend request calls non-blocking
1. **\[P2\]** introducing some kind of tracing into the test

### Current Issues

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ apply plugin: "org.jetbrains.kotlin.android"
apply plugin: "kotlinx-serialization"

android {
namespace "org.outline.sdk.connectivity"
namespace "org.getoutline.sdk.example.connectivity"
compileSdkVersion rootProject.ext.compileSdkVersion
defaultConfig {
applicationId "org.outline.sdk.connectivity"
applicationId "org.getoutline.sdk.example.connectivity"
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 1
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.outline.sdk.connectivity
package org.getoutline.sdk.example.connectivity

import kotlinx.serialization.Serializable

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.outline.sdk.connectivity
package org.getoutline.sdk.example.connectivity

import kotlinx.serialization.Serializable

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.outline.sdk.connectivity
package org.getoutline.sdk.example.connectivity

import android.os.Bundle
import com.getcapacitor.BridgeActivity
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package org.outline.sdk.connectivity
package org.getoutline.sdk.example.connectivity

import com.getcapacitor.JSObject
import com.getcapacitor.Plugin
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
<resources>
<string name="app_name">@outline_sdk_connectivity_demo/app_mobile</string>
<string name="title_activity_main">@outline_sdk_connectivity_demo/app_mobile</string>
<string name="package_name">org.outline.sdk.connectivity</string>
<string name="custom_url_scheme">org.outline.sdk.connectivity</string>
<string name="package_name">org.getoutline.sdk.example.connectivity</string>
<string name="custom_url_scheme">org.getoutline.sdk.example.connectivity</string>
</resources>
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { CapacitorConfig } from '@capacitor/cli';

let config: CapacitorConfig = {
appId: "org.outline.sdk.connectivity",
appId: "org.getoutline.sdk.example.connectivity",
appName: "@outline_sdk_connectivity_demo/app_mobile",
webDir: "output/frontend",
server: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@
);
MARKETING_VERSION = 1.0;
OTHER_SWIFT_FLAGS = "$(inherited) \"-D\" \"COCOAPODS\" \"-DDEBUG\"";
PRODUCT_BUNDLE_IDENTIFIER = org.outline.sdk.connectivity;
PRODUCT_BUNDLE_IDENTIFIER = org.getoutline.sdk.example.connectivity;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
SWIFT_OBJC_BRIDGING_HEADER = "App/App-Bridging-Header.h";
Expand All @@ -398,7 +398,7 @@
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = org.outline.sdk.connectivity;
PRODUCT_BUNDLE_IDENTIFIER = org.getoutline.sdk.example.connectivity;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "";
SWIFT_OBJC_BRIDGING_HEADER = "App/App-Bridging-Header.h";
Expand Down

0 comments on commit ddd6116

Please sign in to comment.