Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce Func Endpoints and Dialers #153

Merged
merged 2 commits into from
Jan 2, 2024
Merged

feat: introduce Func Endpoints and Dialers #153

merged 2 commits into from
Jan 2, 2024

Conversation

fortuna
Copy link
Contributor

@fortuna fortuna commented Jan 2, 2024

This makes it easier to create Endpoints and Dialers "on the fly", without having to define a type.
I need it in the DNS library PR, but I want to use it to extend the config as well with fixed dialers and matchers.

@fortuna fortuna requested a review from jyyi1 January 2, 2024 16:23
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some suggestions to the test.

transport/packet_test.go Show resolved Hide resolved
transport/packet_test.go Outdated Show resolved Hide resolved
transport/stream_test.go Outdated Show resolved Hide resolved
transport/stream_test.go Show resolved Hide resolved
Co-authored-by: J. Yi <93548144+jyyi1@users.noreply.github.com>
@fortuna fortuna merged commit ec5ce29 into main Jan 2, 2024
6 checks passed
@fortuna fortuna deleted the fortuna-func branch January 2, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants