BREAKING: Cleanup core transport library #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename Connect to Stream|Packet Rename direct Dialers Rename UDPPacketListener Update x Fix mod
fortuna
force-pushed
the
fortuna-rename
branch
from
5d2a70b to
f09c820
Compare
fortuna
changed the title
Co-authored-by: J. Yi <93548144+jyyi1@users.noreply.github.com>
|
FYI, I removed the new Dialer and Endpoint interfaces that I was adding. They may be bloat, I don't really think we need them for now. We can easily add them later if we realize the need, but I'd rather keep things lean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCPStreamDialer->TCPDialer, which is shorter and consistent with the already existingTCPEndpoint(same for UDP).Introduced Endpoint and Dialer types that encapsulate TCP and UDP.