feat: create dns.NewStreamDialer #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
approved these changes
Feb 16, 2024
dns/stream_dialer.go
Outdated
|
|
||
| // NewStreamDialer creates a [transport.StreamDialer] that uses Happy Eyeballs v2 to establish a connection. | ||
| // It uses resolver to map host names to IP addresses, and the given dialer to attempt connections. | ||
| func NewStreamDialer(resolver Resolver, dialer transport.StreamDialer) transport.StreamDialer { |
There was a problem hiding this comment.
Shall we use (transport.StreamDialer, error) as the return type to align with other functions (also in case in the future we might return errors, so the caller don't need to change the code)? Even in this function, we can return errors if either resolver or dialer is nil.
There was a problem hiding this comment.
Good point. I've updated as per your suggestion
jyyi1
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows people to create dialers from Resolvers and actually use the dns library.