Adding username/password parameters to Socks5 config URL #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e793764.
|
I had to change |
fortuna
reviewed
Mar 25, 2024
x/go.mod
Outdated
| @@ -3,13 +3,13 @@ module github.com/Jigsaw-Code/outline-sdk/x | |||
| go 1.20 | |||
|
|
|||
| require ( | |||
| github.com/Jigsaw-Code/outline-sdk v0.0.14 | |||
| github.com/Jigsaw-Code/outline-sdk v0.0.0-20240322232535-212ef9692e98 | |||
There was a problem hiding this comment.
Please use the new v0.0.15
fortuna
approved these changes
Mar 26, 2024
fortuna
reviewed
Mar 26, 2024
| "github.com/Jigsaw-Code/outline-sdk/transport/socks5" | ||
| ) | ||
|
|
||
| func newSOCKS5StreamDialerFromURL(innerDialer transport.StreamDialer, configURL *url.URL) (transport.StreamDialer, error) { |
There was a problem hiding this comment.
Please update the Go doc with the new parameter. It doesn't show the credentials currently: https://pkg.go.dev/github.com/Jigsaw-Code/outline-sdk/x/config
There was a problem hiding this comment.
@fortuna good catch! it slipped my mind. I updated the doc to include authentication params (UserInfo) in the URL.
fortuna
approved these changes
Mar 26, 2024
fortuna
pushed a commit
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds username and password params for authentication to socks5 config URL used to set up the dialer. The URL now accepts
UserInfoparameter in form ofusername:password. For example:socks5://username:password@domain.com:portThis change was tested with a socks5 proxy server by running connectivity test: