Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DoH Config #227

Merged
merged 2 commits into from
May 1, 2024
Merged

Add DoH Config #227

merged 2 commits into from
May 1, 2024

Conversation

fortuna
Copy link
Contributor

@fortuna fortuna commented Apr 29, 2024

This lets use have a fully working transport for HTTPS:

go run github.com/Jigsaw-Code/outline-sdk/x/examples/fetch@latest -transport 'doh:name=cloudflare-dns.com.&address=cloudflare.net.:443|tlsfrag:1' https://meduza.io/

@fortuna fortuna requested review from jyyi1 and amircybersec April 29, 2024 21:36
@fortuna fortuna enabled auto-merge (squash) April 30, 2024 21:58
@fortuna
Copy link
Contributor Author

fortuna commented May 1, 2024

Ping

Copy link
Contributor

@amircybersec amircybersec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. I just have a question. In your example, you have a dot . after name and address. Is that necessary or part of the name and address?

doh:name=cloudflare-dns.com.&address=cloudflare.net.:443

@fortuna fortuna merged commit 6361b97 into main May 1, 2024
6 checks passed
@fortuna fortuna deleted the fortuna-doh branch May 1, 2024 18:42
@fortuna
Copy link
Contributor Author

fortuna commented May 1, 2024

@amircybersec It's not necessary. It just makes sure it uses the root dns, rather than doing domain search completion, which happens in my work environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants