feat: allow unencoded userinfo as per SIP002
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
reviewed
Jul 15, 2024
fortuna
reviewed
Jul 15, 2024
sbruens
force-pushed
the
sbruens/optional-b64
branch
from
eb3f837 to
435f8a3
Compare
fortuna
approved these changes
Jul 15, 2024
amircybersec
pushed a commit
that referenced
this pull request
Sep 6, 2024
* feat: allow unencoded `userinfo` as per SIP002 * Move shadowsocks config tests to `shadowsocks_test.go` and clean up. * Review comment. * Add test case for invalid cipher info (e.g. missin colon). * Remove unnecessary prefix in test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encoding
userinfowith Base64URL is optional. See https://shadowsocks.org/doc/sip002.html#sip002-uri-scheme.