connectivity test app (without android) #54

daniellacosse · 2023-08-23T01:20:14Z

README: https://github.com/Jigsaw-Code/outline-sdk/tree/outline-connectivity-app/x/outline-connectivity-app

can't find activity... revert local ip start architecture overview finish 1st draft of docs remove android

fortuna

Initial review. Root directory only.

x/outline-connectivity-app/package.json

x/outline-connectivity-app/.vscode/extensions.json

x/outline-connectivity-app/.gitignore

x/outline-connectivity-app/.vscode/settings.json

x/outline-connectivity-app/package.json

x/outline-connectivity-app/tsconfig.json

x/outline-connectivity-app/tsconfig.node.json

Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>

fortuna

Review for app_desktop, shared_backend and the IPC system.

x/outline-connectivity-app/app_mobile/app.ts

x/outline-connectivity-app/app_desktop/main.go

x/outline-connectivity-app/app_desktop/package.json.md5

x/outline-connectivity-app/shared_backend/main.go

x/outline-connectivity-app/app_desktop/generated/wailsjs/go/main/App.js

x/outline-connectivity-app/shared_backend/main.go

x/outline-connectivity-app/app_desktop/app.ts

x/outline-connectivity-app/shared_backend/index.ts

jyyi1

Thanks for the contribution! It's very useful.

x/examples/outline-connectivity-app/.pnp.cjs

x/examples/outline-connectivity-app/.pnp.loader.mjs

x/examples/outline-connectivity-app/.vscode/settings.json

x/examples/outline-connectivity-app/.yarn/plugins/@yarnpkg/plugin-typescript.cjs

x/examples/outline-connectivity-app/README.md

x/examples/outline-connectivity-app/shared_backend/package.json

x/examples/outline-connectivity-app/shared_frontend/assets/fonts/jigsaw_sans/bold.woff2

x/examples/outline-connectivity-app/shared_frontend/index.ts

x/examples/outline-connectivity-app/shared_frontend/package.json

...outline-connectivity-app/shared_frontend/pages/connectivity_test/generated/messages/index.ts

Co-authored-by: J. Yi <93548144+jyyi1@users.noreply.github.com>

daniellacosse · 2023-08-31T18:36:15Z

Note I'm going to be closing comments that don't have action items - this is just for my own sanity. Feel free to reopen anything you disagree with!

jyyi1

Thanks! Though some generated code is still required, it's much cleaner, and my GitHub isn't stuck any more. The code looks good, added a few small comments.

x/examples/outline-connectivity-app/.gitignore

x/examples/outline-connectivity-app/README.md

x/examples/outline-connectivity-app/app_mobile/index.html

x/outline-connectivity-app/go.mod

x/examples/outline-connectivity-app/shared_backend/main.go

fortuna

Review for shared_backend

x/examples/outline-connectivity-app/shared_frontend/pages/connectivity_test/localize.json

x/examples/outline-connectivity-app/shared_frontend/pages/connectivity_test/index.ts

x/examples/outline-connectivity-app/shared_frontend/pages/connectivity_test/types.ts

…ectivity_test/localize.json Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>

…Code/outline-internal-sdk into outline-connectivity-app

fortuna

Code looks good. The IPC calls are a lot easier to understand, thanks for the changes.
There's a README comment that you can fix, and we should use the config library, but that can be in another PR.

x/examples/outline-connectivity-app/README.md

x/examples/outline-connectivity-app/shared_backend/main.go

daniellacosse · 2023-09-13T09:30:17Z

Great! I just need to make sure everything's working still 😅

daniellacosse changed the title ~~connectivity test app~~ [WIP] connectivity test app Aug 23, 2023

daniellacosse mentioned this pull request Aug 23, 2023

wails connectivity test demo #36

Closed

daniellacosse marked this pull request as draft August 23, 2023 15:06

daniellacosse changed the title ~~[WIP] connectivity test app~~ connectivity test app Aug 30, 2023

daniellacosse changed the title ~~connectivity test app~~ connectivity test app, sans android Aug 30, 2023

daniellacosse changed the title ~~connectivity test app, sans android~~ connectivity test app (without android) Aug 30, 2023

daniellacosse marked this pull request as ready for review August 30, 2023 15:46

daniellacosse requested review from fortuna and jyyi1 August 30, 2023 15:47

add initial test app

f710178

can't find activity... revert local ip start architecture overview finish 1st draft of docs remove android

daniellacosse force-pushed the outline-connectivity-app branch from 8e0abd7 to f710178 Compare August 30, 2023 15:48

fortuna requested changes Aug 30, 2023

View reviewed changes

daniellacosse and others added 2 commits August 30, 2023 13:41

Merge branch 'main' into outline-connectivity-app

a8dcdc4

Update x/outline-connectivity-app/go.mod

83f9359

Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>

fortuna requested changes Aug 30, 2023

View reviewed changes

move folder, run go mod tidy

55285bf

daniellacosse requested a review from fortuna August 30, 2023 17:56

jyyi1 reviewed Aug 30, 2023

View reviewed changes

daniellacosse and others added 2 commits August 31, 2023 14:21

Update x/examples/outline-connectivity-app/shared_frontend/index.ts

5886b41

Co-authored-by: J. Yi <93548144+jyyi1@users.noreply.github.com>

Update x/examples/outline-connectivity-app/package.json

7872ea7

Co-authored-by: J. Yi <93548144+jyyi1@users.noreply.github.com>

daniellacosse requested a review from jyyi1 August 31, 2023 18:35

daniellacosse added 4 commits September 6, 2023 15:07

adds licenses and updates go.mod path

fe0c58b

address all feedback but the refactoring ones

42b861e

remove pnp files

be74d8c

revert generated/wailsjs - wails generate module dosen't workj

f1f4630

jyyi1 reviewed Sep 6, 2023

View reviewed changes

fortuna reviewed Sep 6, 2023

View reviewed changes

daniellacosse and others added 2 commits September 7, 2023 11:48

Update x/examples/outline-connectivity-app/shared_frontend/pages/conn…

d72e369

…ectivity_test/localize.json Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>

wip

c896bf1

daniellacosse added 3 commits September 11, 2023 15:11

renaming to request

27f5f9b

Merge branch 'outline-connectivity-app' of https://github.com/Jigsaw-…

ff679bd

…Code/outline-internal-sdk into outline-connectivity-app

fix types and update docs

198433f

daniellacosse requested review from fortuna and jyyi1 September 11, 2023 15:05

daniellacosse added 3 commits September 11, 2023 16:10

add todo

c1227bf

move ConnectivityTest check inside if statement

6984d5e

update todos in README

cd51fbb

fortuna approved these changes Sep 12, 2023

View reviewed changes

x/examples/outline-connectivity-app/README.md Show resolved Hide resolved

x/examples/outline-connectivity-app/shared_backend/main.go Show resolved Hide resolved

daniellacosse added 2 commits September 13, 2023 10:24

fix diagram and add TODO for generic parser

7de8aec

okay THAT should work

4d43597

daniellacosse added 2 commits September 13, 2023 13:46

fix ipv6 resolver, and language switcher

630c1b3

fix translation switcher

cccf239

daniellacosse requested a review from fortuna September 13, 2023 12:59

add TODO for test result output

6623399

fortuna approved these changes Sep 13, 2023

View reviewed changes

jyyi1 approved these changes Sep 13, 2023

View reviewed changes

daniellacosse merged commit 278ec10 into main Sep 14, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

connectivity test app (without android) #54

connectivity test app (without android) #54

daniellacosse commented Aug 23, 2023 •

edited

Loading

fortuna left a comment

fortuna left a comment

jyyi1 left a comment

daniellacosse commented Aug 31, 2023

jyyi1 left a comment

fortuna left a comment

fortuna left a comment

daniellacosse commented Sep 13, 2023 •

edited

Loading

connectivity test app (without android) #54

connectivity test app (without android) #54

Conversation

daniellacosse commented Aug 23, 2023 • edited Loading

fortuna left a comment

Choose a reason for hiding this comment

fortuna left a comment

Choose a reason for hiding this comment

jyyi1 left a comment

Choose a reason for hiding this comment

daniellacosse commented Aug 31, 2023

jyyi1 left a comment

Choose a reason for hiding this comment

fortuna left a comment

Choose a reason for hiding this comment

fortuna left a comment

Choose a reason for hiding this comment

daniellacosse commented Sep 13, 2023 • edited Loading

daniellacosse commented Aug 23, 2023 •

edited

Loading

daniellacosse commented Sep 13, 2023 •

edited

Loading