Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 1.21.4 #262

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Add support for 1.21.4 #262

merged 4 commits into from
Dec 9, 2024

Conversation

Jikoo
Copy link
Owner

@Jikoo Jikoo commented Dec 6, 2024

This is the initial copy+paste+compilation fix of the 1.21.3 adapter. I have not yet had time to explore the changes.

TODO for release:

  • Check game mode field
  • Check player tag deserialization
  • Update resource pack versioning if necessary
  • Investigate potential for increased compatibility with other resource packs via String-based custom model data
  • Fix empty armor slot textures

/e: Numbers are hard.
As always, standard disclaimer about how I have not tested this in game yet. It looks like it should work fine, but if you're downloading a build from an Actions run, please be sure to try it on your test server before pushing to production.

@Jikoo Jikoo linked an issue Dec 6, 2024 that may be closed by this pull request
@Jikoo Jikoo changed the title Add support for 1.20.4 Add support for 1.21.4 Dec 6, 2024
Empty textures are a problem, may resort to copying in default textures if I can't figure it out.
@Jikoo
Copy link
Owner Author

Jikoo commented Dec 8, 2024

If anyone happens to know how to access GUI textures in items, please let me know. The empty slot textures have moved from assets/minecraft/textures/item/empty_armor_slot_<slot> to assets/minecraft/textures/gui/sprites/container/slot/<slot>, and I can't figure out how to get them to load.
To my understanding, the resource location should be relative to assets/minecraft/textures by default with the minecraft key, so minecraft:gui/sprites/container/slot/boots should load assets/minecraft/textures/gui/sprites/container/slot/boots.png.

I will likely resort to just copying the textures, but I'm not happy about it. I'd rather not duplicate resources that technically could be eligible for DMCA.

/e: In case anyone else runs into this problem, it does not appear to be possible. Internally, all references to the textures I want to use are referenced by minecraft:container/slot/<slot> from a different atlas. Since the textures aren't in the blocks atlas at all, they can't be accessed by items.
It might theoretically be possible to bundle symlinks instead of copies of the textures, but I don't know how that would work for cross-system compatibility of the pack. It also would still require the textures to be loaded into memory twice, so it doesn't really save resources.

Jikoo added 2 commits December 8, 2024 18:15
Based on logs, GUI textures are not included in the texture atlas available to us.
Doesn't impact anything as blocks don't display custom model data when placed, but we like clean logs.
@Jikoo Jikoo merged commit 5ac09bc into master Dec 9, 2024
2 checks passed
@Jikoo Jikoo deleted the dev/v1_20_R3 branch December 9, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to 1.21.4
1 participant