Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fiction.live last update not being included? #672

Closed
JimmXinu opened this issue Mar 19, 2021 · 5 comments
Closed

fiction.live last update not being included? #672

JimmXinu opened this issue Mar 19, 2021 · 5 comments

Comments

@JimmXinu
Copy link
Owner

@HazelSh,

There's a report on MR that the last update isn't always being included in fiction.live downloads.

Do you have time to take a look at it?

@HazelSh
Copy link

HazelSh commented Mar 20, 2021

Will do.

@HazelSh
Copy link

HazelSh commented Mar 20, 2021

Had an off-by-one error in the interaction between the most-recent-chuck timestamp tracker and the add_chapter_url function. Feeling a bit silly. Gonna go update the fictionlive stories I'm following.

Thanks to chrnno on mobileread for the minimal test case, which made isolating the issue very simple.

I believe that the difference between the two offered test cases is that, for the other story where the issue wasn't happening, the most recent update was an appendix -- those hit a slightly different code path which didn't have the bug.

HazelSh pushed a commit to HazelSh/FanFicFare that referenced this issue Mar 20, 2021
@JimmXinu
Copy link
Owner Author

@HazelSh, Thanks for taking care of this!

@JimmXinu
Copy link
Owner Author

Test versions up in the usual places.

@HazelSh
Copy link

HazelSh commented Mar 20, 2021

No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants