Skip invalid images #1068
Merged
Skip invalid images #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimmXinu
reviewed
May 11, 2024
| # doesn't have extension? use jpg. | ||
| ext='jpg' | ||
| try: | ||
| from PIL import Image |
There was a problem hiding this comment.
FFF doesn't require pillow(for PIL) for CLI users who don't want images.
Are you happy with the existing error reporting for not having PIL?
FFF: INFO: 2024-05-11 13:35:07,828: story.py(1670): Failed to load or convert image,
parent:http://test1.com?sid=1010&chapter=1
skipping:file:///C:/Users/uname/fff logo images/film-reel.jpeq
Exception: No module named 'PIL'
|
Now this should handle the lack of modules better. |
|
It'll be in the next test version, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading images with the 'no_convert_image' if the image was for example deleted the plugin pulls garbage and makes 0B image. This may solve the problem when downloading the images with no extension will result in a proper extension being applied instead of just jpg.