Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpiritFanfiction #1078

Merged
merged 1 commit into from
Jun 9, 2024
Merged

SpiritFanfiction #1078

merged 1 commit into from
Jun 9, 2024

Conversation

kilandra
Copy link
Contributor

@kilandra kilandra commented Jun 1, 2024

Adds support to www.spiritfanfiction.com

JimmXinu
JimmXinu requested changes Jun 3, 2024
View reviewed changes
Copy link
Owner

@JimmXinu JimmXinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this, but there are some issues that should be addressed.

fanficfare/adapters/adapter_spiritfanfictioncom.py Outdated Show resolved Hide resolved
fanficfare/adapters/adapter_spiritfanfictioncom.py Outdated Show resolved Hide resolved
fanficfare/adapters/adapter_spiritfanfictioncom.py Outdated Show resolved Hide resolved
fanficfare/adapters/adapter_spiritfanfictioncom.py Outdated Show resolved Hide resolved
fanficfare/adapters/adapter_spiritfanfictioncom.py Outdated Show resolved Hide resolved
fanficfare/adapters/adapter_spiritfanfictioncom.py Outdated Show resolved Hide resolved
fanficfare/adapters/adapter_spiritfanfictioncom.py Show resolved Hide resolved
fanficfare/adapters/adapter_spiritfanfictioncom.py Show resolved Hide resolved
@kilandra
SpiritFanfiction
64dd54d 
Add support to spiritfanfiction.com
@kilandra kilandra force-pushed the SpiritFanfiction branch from 175fbf5 to 64dd54d Compare June 8, 2024 14:59
@kilandra kilandra requested a review from JimmXinu June 9, 2024 00:59
@JimmXinu JimmXinu mentioned this pull request Jun 9, 2024
Closed
@JimmXinu JimmXinu merged commit 33b2b10 into JimmXinu:main Jun 9, 2024
@JimmXinu
Copy link
Owner

JimmXinu commented Jun 9, 2024

Thanks. Test versions up in the usual places.

@kilandra kilandra deleted the SpiritFanfiction branch June 10, 2024 11:18
@kilandra
Copy link
Contributor Author

Thank you, I tested with many different links and it's working fine.
I forgot to mention before, this will solve issue #969

@JimmXinu JimmXinu mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimmXinu JimmXinu Awaiting requested review from JimmXinu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kilandra @JimmXinu