Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates are not correctly detected on Deviantart #910

Closed
wants to merge 5 commits into from

Conversation

bugmaschine
Copy link
Contributor

If the dates are formated like "3 days ago" for example its causes a crash

@bugmaschine bugmaschine marked this pull request as ready for review January 22, 2023 09:54
@JimmXinu
Copy link
Owner

Have you looked at the existing parse_relative_date_string() in fanficfare/dateutils.py? It seems to be very similar.

@bugmaschine
Copy link
Contributor Author

I modified the code to use the existing function, but the existing code had to be modified i hope this works

Copy link
Owner

@JimmXinu JimmXinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closer, but not quite there.

fanficfare/adapters/adapter_deviantartcom.py Outdated Show resolved Hide resolved
fanficfare/dateutils.py Outdated Show resolved Hide resolved
fanficfare/dateutils.py Outdated Show resolved Hide resolved
C
This should be bette
@bugmaschine
Copy link
Contributor Author

Maybe now?

@bugmaschine bugmaschine requested a review from JimmXinu January 23, 2023 15:23
JimmXinu added a commit that referenced this pull request Jan 23, 2023
@JimmXinu
Copy link
Owner

This still needed some tweaking and I didn't want to spend more time going back and forth. Merged in with 5ce7aa5

Please test, I couldn't find and deviantart stories with Yesterday or just now.

@JimmXinu JimmXinu closed this Jan 23, 2023
@bugmaschine
Copy link
Contributor Author

Tested it with Yesterday and just now and both work

@JimmXinu
Copy link
Owner

Okay, thanks.

mvlcek pushed a commit to mvlcek/FanFicFare that referenced this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants