Fix file permission on GitHub gpu runners #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to use
cuda-toolkitwith the official GitHub Actions GPU-runners, the log file'/var/log/cuda-installer.log'ends up not having read permissions for the default user. Because the base nvidia image has strange permissions (presumably for security reasons), when the installation of the cuda toolkit is done withsudo, the file is created by root, and is inaccessible to others. Consequently, theuploadArtifactfunction for that log file will fail.This PR resets the file permissions for log files before calling
uploadArtifact. I have tested this on a private repo, and I can successfully run the action with the change in this PR.Thank you @robandpdx for the initial investigation in this comment.