Skip to content

two question maybe an issue #1

Closed
@StephanElter

Description

@StephanElter

Hey JingShing
nice job providing this. :)
i have prob two findings:

  1. if color >= (color>>2) > matrix[row&matrix_len][col&matrix_len]:
    do you really need the first condition? the first condition is always fullfilled
  2. i guess the indexing formula e.g. row&matrix_len does only work for 8,4 and 2 but not for 3 or isnt it?
    in case of 3 you get only index of 0 or 2 but never 1. i guess you want do somthing like modulo or?
    regards Stephan

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions