Skip to content

two question maybe an issue #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StephanElter opened this issue Aug 22, 2023 · 1 comment
Closed

two question maybe an issue #1

StephanElter opened this issue Aug 22, 2023 · 1 comment

Comments

@StephanElter
Copy link

Hey JingShing
nice job providing this. :)
i have prob two findings:

  1. if color >= (color>>2) > matrix[row&matrix_len][col&matrix_len]:
    do you really need the first condition? the first condition is always fullfilled
  2. i guess the indexing formula e.g. row&matrix_len does only work for 8,4 and 2 but not for 3 or isnt it?
    in case of 3 you get only index of 0 or 2 but never 1. i guess you want do somthing like modulo or?
    regards Stephan
@JingShing
Copy link
Member

Sorry for your problems. That these codes are my old codes so it may be silly or broke.

first question. That I was experimenting some feature so some condition or part may look useless.

Seconed question. Ya I just do the modulo or but maybe in that time I just don't know this operator.

Sorry for your problems. This repo is for my note or experiment code. And it is my old codes. Thanks for your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants