Include the option to get the latest xkcd #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets rid of a yikes try-except I added.
Also add type hint for Red.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything works as one would expect, but
[p]xkcd latestwill get the latest xkcd. I also cleaned up a bit of code by abstracting the xkcd query and reusing aiohttp sessions, and I changed the date format to be more universal (year-month-day is pretty widely accepted, even in the U.S.).Edit: For the record, I license the contributions authored in this pull request under both the terms of the repository per GitHub's ToS, as well as, at your option,
AGPL-3.0-or-later, in hopes of an easier transition to an "or later" version for the whole project, should you wish to do so.