changed route params to avoid deploy issues

JiscSD · Mar 1, 2023 · 112ea5f · 112ea5f
1 parent 7916d2f
commit 112ea5f
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/api/serverless.yml b/api/serverless.yml
@@ -289,7 +289,7 @@ functions:
         handler: src/components/coauthor/routes.sendApprovalReminder
         events:
             - http:
-                  path: ${self:custom.versions.v1}/publications/{publicationId}/coauthors/{authorId}/approval-reminder
+                  path: ${self:custom.versions.v1}/publications/{id}/coauthors/{coauthor}/approval-reminder
                   method: POST
                   cors: true
     getFlag:

diff --git a/api/src/components/coauthor/controller.ts b/api/src/components/coauthor/controller.ts
@@ -13,6 +13,7 @@ export const get = async (
         return response.json(200, coAuthors);
     } catch (err) {
         console.log(err);
+
         return response.json(500, { message: 'Unknown server error.' });
     }
 };
@@ -147,6 +148,7 @@ export const remove = async (
         return response.json(200, { message: 'Co-author deleted from this publication' });
     } catch (err) {
         console.log(err);
+
         return response.json(500, { message: 'Unknown server error.' });
     }
 };
@@ -242,6 +244,7 @@ export const link = async (
         return response.json(200, 'Linked user account');
     } catch (err) {
         console.log(err);
+
         return response.json(500, { message: 'Unknown server error.' });
     }
 };
@@ -307,6 +310,7 @@ export const updateConfirmation = async (
         return response.json(200, { message: 'This co-author has changed their confirmation status.' });
     } catch (err) {
         console.log(err);
+
         return response.json(500, { message: 'Unknown server error.' });
     }
 };
@@ -344,14 +348,15 @@ export const requestApproval = async (
         return response.json(200, coAuthors);
     } catch (err) {
         console.log(err);
+
         return response.json(500, { message: 'Unknown server error.' });
     }
 };
 
 export const sendApprovalReminder = async (
     event: I.AuthenticatedAPIRequest<undefined, undefined, I.SendApprovalReminderPathParams>
 ): Promise<I.JSONResponse> => {
-    const { authorId, publicationId } = event.pathParameters;
+    const { coauthor: authorId, id: publicationId } = event.pathParameters;
 
     const publication = await publicationService.get(publicationId);
     const author = await coAuthorService.get(authorId);
@@ -419,6 +424,7 @@ export const sendApprovalReminder = async (
         await coAuthorService.update(authorId, { reminderDate: new Date() });
     } catch (error) {
         console.log(error);
+
         return response.json(500, { message: 'Unknown server error' });
     }
 

diff --git a/api/src/components/coauthor/schema/sendApprovalReminder.ts b/api/src/components/coauthor/schema/sendApprovalReminder.ts
@@ -3,14 +3,14 @@ import * as I from 'interface';
 const sendApprovalReminder: I.JSONSchemaType<I.SendApprovalReminderPathParams> = {
     type: 'object',
     properties: {
-        authorId: {
+        coauthor: {
             type: 'string'
         },
-        publicationId: {
+        id: {
             type: 'string'
         }
     },
-    required: ['authorId', 'publicationId']
+    required: ['coauthor', 'id']
 };
 
 export default sendApprovalReminder;
diff --git a/api/src/lib/interface.ts b/api/src/lib/interface.ts
@@ -558,6 +558,6 @@ export interface UserPublicationsFilters {
 }
 
 export interface SendApprovalReminderPathParams {
-    publicationId: string;
-    authorId: string;
+    id: string;
+    coauthor: string;
 }