OC-81: Disable confirmation buttons whilst operation is already in progress #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR was to prevent users from resubmitting a modal action while the backend request was pending, by indicating that it is in progress and disabling the modal buttons.
I changed the Modal component we use, but not the ConfirmationModal context, because that closes as soon as an option is selected and already displays a loading bar on the page if applicable.
Also made a small adjustment to an e2e test to make it run a bit more reliably.
Acceptance Criteria:
As per OC-81
Checklist:
Tests:
UI:
E2E:
