Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-714 Rename/Split API endpoints and organise services/controllers to reflect the actual resources #505

Merged
merged 20 commits into from
Oct 13, 2023

Conversation

florin-holhos
Copy link
Contributor

@florin-holhos florin-holhos commented Oct 4, 2023

The purpose of this PR was to adapt API endpoints and services to the new Publication and Publication Version structure.
This also involved UI changes to use the new endpoints and services.


Acceptance Criteria:

As per OC-714


Checklist:

  • Local manual testing conducted
  • Automated tests added/updated
  • Documentation updated

Tests:

image image

Screenshots:

@florin-holhos florin-holhos marked this pull request as ready for review October 6, 2023 06:23
@florin-holhos florin-holhos requested a review from a team as a code owner October 6, 2023 06:23
api/src/components/coauthor/controller.ts Outdated Show resolved Hide resolved
api/src/components/publication/controller.ts Show resolved Hide resolved
api/src/components/publication/controller.ts Outdated Show resolved Hide resolved
api/src/components/publication/service.ts Outdated Show resolved Hide resolved
api/src/components/publication/service.ts Outdated Show resolved Hide resolved
ui/src/pages/authors/[id]/index.tsx Outdated Show resolved Hide resolved
api/serverless.yml Outdated Show resolved Hide resolved
@florin-holhos florin-holhos merged commit 077a66c into versioning Oct 13, 2023
florin-holhos added a commit that referenced this pull request Oct 13, 2023
…o reflect the actual resources (#505)

* finished dev work

* fixed api tests

* fixed flag and topics endpoints

* fixed TS type error

* fixed e2e tests and improved app performance

* removed unused components

* fixed eslint issues

* fixed e2e tests

* removed unused publication endpoint

* removed tests for inexistent endpoint

* renamed isReadyTo... to checkIsReadyTo... services

* added extra check on /publications/{id}

* added "latestLive" option for getting pub version

* removed unused publication service

* added ownership checks for /links endpoint

* renamed publication to publicationVersion in tests

* renamed link with linkedPublication

* fixed empty published date

* renamed userPublicationsUrl variable

* renamed pub version endpoints and updated tests

---------

Co-authored-by: Florin H <florin.holhos@wingravity.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants