Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-700 Spike: re-enable server-side rendering #508

Merged
merged 4 commits into from
Oct 10, 2023
Merged

OC-700 Spike: re-enable server-side rendering #508

merged 4 commits into from
Oct 10, 2023

Conversation

florin-holhos
Copy link
Contributor

@florin-holhos florin-holhos commented Oct 6, 2023

The purpose of this PR was to restore SSR for all pages.

In all those places where we used client side hooks like useMediaQuery, I had to remove the hook and replace it with CSS. That means the markup of the page is available all the time, but only parts of it are visible based on the screen size.


Acceptance Criteria:


Checklist:

  • Local manual testing conducted
  • Automated tests updated
  • Documentation updated

Tests:

image

Screenshots:

@florin-holhos florin-holhos requested a review from a team as a code owner October 6, 2023 11:58
@florin-holhos florin-holhos merged commit 623810e into main Oct 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants