Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning migration fixups #512

Closed
wants to merge 3 commits into from
Closed

Conversation

finlay-jisc
Copy link
Collaborator

The purpose of this PR was to fix some issues with the versioning migration script that are preventing us from running it properly on AWS.

There were some basic formatting changes to the prisma schema and versioning migration guide.

I've followed through the steps in the updated guide locally to confirm that they still work. In a slight change to the process I've included the script in the same commit as the first DB migration, so that's now run before checking out the second commit.

The seed script still runs OK after recreating the DB migrations.


Acceptance Criteria:

  • Clean up any changes from previous attempts of running the script so that we don't always have to restore the database after a failed attempt
  • Don't run lots of database tasks in parallel because it will use up the available connection pools. Instead, run them one after another

Checklist:

  • Local manual testing conducted
  • Automated tests added
  • Documentation updated

@finlay-jisc finlay-jisc requested a review from a team as a code owner October 13, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant