Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-633: Change error message when users raise a duplicate red flag #515

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

finlay-jisc
Copy link
Collaborator

@finlay-jisc finlay-jisc commented Oct 17, 2023

The purpose of this PR was to display an informative error message when the user attempts to create a flag that they have already created one of the same type for on the current publication. The API was already sending a message but the UI was not set up to display it.

I ran into a hydration error while working on this so made some adjustments to prevent these wherever we are using dates/times formatted with toLocaleString().


Acceptance Criteria:

As per OC-633.


Checklist:

  • Local manual testing conducted
  • Automated tests added
  • Documentation updated

Tests:

E2E:
Screenshot 2023-10-17 111949

UI:
Screenshot 2023-10-16 160636

API:
Screenshot 2023-10-16 161202


Screenshots:

Screenshot 2023-10-17 112923

@finlay-jisc finlay-jisc requested a review from a team as a code owner October 17, 2023 10:29
@florin-holhos florin-holhos merged commit b5d3ad7 into main Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants