Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-725: Revert change to force co-authors to accept with the email they were invited with #528

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

finlay-jisc
Copy link
Collaborator

The purpose of this PR was to remove a check that disallowed co-authors from accepting an invitation if they were logged in using a different email from the one that their invitation email was sent to.

I removed a comment related to the versioning migration from the schema file and the changes in that file are just that removal and some formatting.


Acceptance Criteria:

  • The email address for the user accepting an invitation to be a co-author does not need to match the one they were invited with.

Checklist:

  • Local manual testing conducted
  • Automated tests added - (one removed)
  • Documentation updated

Tests:

UI
Screenshot 2023-11-02 112944

E2E
Screenshot 2023-11-02 112929

API
Screenshot 2023-11-02 112920

@finlay-jisc finlay-jisc requested a review from a team as a code owner November 2, 2023 11:34
florin-holhos and others added 2 commits November 6, 2023 12:06
* finished script, API and UI work

* fixed ts issue after rebase

* fixed alias paths when running seed

* fixed createVersionedDOIs script

---------

Co-authored-by: Florin H <florin.holhos@wingravity.com>
@florin-holhos florin-holhos merged commit d617e7e into main Nov 13, 2023
9 checks passed
finlay-jisc added a commit that referenced this pull request Nov 17, 2023
…ey were invited with (#528)

* allow coauthors to accept with different email

* OC-389 Versioned DOIs (#527)

* finished script, API and UI work

* fixed ts issue after rebase

* fixed alias paths when running seed

* fixed createVersionedDOIs script

---------

Co-authored-by: Florin H <florin.holhos@wingravity.com>

---------

Co-authored-by: florin-holhos <48569671+florin-holhos@users.noreply.github.com>
Co-authored-by: Florin H <florin.holhos@wingravity.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants