Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-720: Email preview improvements #529

Merged
merged 3 commits into from
Nov 15, 2023
Merged

OC-720: Email preview improvements #529

merged 3 commits into from
Nov 15, 2023

Conversation

finlay-jisc
Copy link
Collaborator

The purpose of this PR was to improve the appearance of email previews in email client applications.

For AC 1 the best I could do is to have the name followed by the address, i.e. "Octopus.ac noreply@prod.octopus.ac".
For AC 2 I found a way of setting the body preview / snippet but won't be able to test this properly until the code is deployed to int as we can't send emails locally. The preview text values have been agreed with the PO.


Acceptance Criteria:

  1. The email’s sender should be “Octopus.ac” instead of the email address itself.
  2. Emails from Octopus display the first line of the email body’s text in the inbox preview, instead of the URL to an image.

Checklist:

  • Local manual testing conducted
  • Automated tests added
  • Documentation updated

Tests:

API:

Screenshot 2023-11-03 093908

E2E:

Screenshot 2023-11-03 093227

@finlay-jisc finlay-jisc requested a review from a team as a code owner November 3, 2023 09:46
api/src/lib/email.ts Outdated Show resolved Hide resolved
@finlay-jisc finlay-jisc merged commit 9c405ea into main Nov 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants