Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-867: Secure docker-compose file #650

Merged
merged 3 commits into from
May 2, 2024
Merged

OC-867: Secure docker-compose file #650

merged 3 commits into from
May 2, 2024

Conversation

finlay-jisc
Copy link
Collaborator

The purpose of this PR was to make changes to the docker-compose file to stop our use of outdated docker images that have security vulnerabilities.

This is mostly using later image versions but two changes were a bit different:

  • Mailhog was swapped out for a similar application called Mailpit which was pretty much like for like. Mailpit is actively updated while mailhog hadn't been updated for some time.
  • Adminer was removed because its latest docker image had vulnerabilities and a similar utility can be got from running npx prisma studio in the /api directory.

Acceptance Criteria:

  • Update vulnerable / outdated software / docker images in use on the docker containers.

Checklist:

  • Local manual testing conducted
  • Automated tests added
  • Documentation updated

Tests:

E2E
Screenshot 2024-04-30 111104

@finlay-jisc finlay-jisc requested a review from a team as a code owner April 30, 2024 12:17
Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octopus ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 8:59am

@finlay-jisc finlay-jisc merged commit f201838 into main May 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants