-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OC-888: Deploying ARI ingests to prod #692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
finlay-jisc
commented
Sep 25, 2024
Just thinking with the moving from offline SSM. Noticed this with working on KSGW, adding the secrets from SSM to the lambda puts the raw secret in the lambda config. I won't put a screenshot here for obvious reasons but something that should be looked at eventually. |
adwearing-jisc
approved these changes
Sep 25, 2024
This reverts commit 8b8b620.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR was to provide a way to manually trigger ARI ingests on prod, rather than only scheduled runs, to avoid timing out the operation or creating a large number of new records unnecessarily.
This PR requires a new environment variable containing recipient emails to be defined before deployment.
Also:
Acceptance Criteria:
Run the script from "OC-884: Create script to create publications for existing ARIs" on prod to populate existing ARIsre-versionedupdated (we update these in place rather than reversion)Checklist:
Tests:
API
E2E
Screenshots:
Email contents (HTML):
Email contents (text):