Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-911: ARI ingest dry runs #694

Merged
merged 3 commits into from
Sep 30, 2024
Merged

OC-911: ARI ingest dry runs #694

merged 3 commits into from
Sep 30, 2024

Conversation

finlay-jisc
Copy link
Collaborator

The purpose of this PR was to add a dry run feature to the ARI integration. In order to test the ARI integration, and to avoid the risk of the ingest timing out if a high number of ARIs need to be updated/created, a dry run feature is needed to check how the ingest will behave before each run.


Acceptance Criteria:

  • The endpoint to run the ingest operation on int or prod now contains a dry run parameter
    • Enabling this option will cause the ingest to run without actually making any changes, including:
      • No new ARIs are created, nor any updates to existing ARIs
      • No updates to the log of previous ingests that was created as part of OC-910
      • The email (see OC-888) is still returned upon completion of the operation, including stats for what would’ve been created

Checklist:

  • Local manual testing conducted
  • Automated tests added
  • Documentation updated

Tests:

E2E
Screenshot 2024-09-26 114359

API
Screenshot 2024-09-26 115625


Screenshots:

Note that the double space before "results" was fixed in a later commit after these screenshots were taken.

Dry run email (HTML/text):
Screenshot 2024-09-26 103729
Screenshot 2024-09-26 103839

Subsequent real run email (HTML/text):
Screenshot 2024-09-26 103903
Screenshot 2024-09-26 103910

This is what would be output in the email if the dry run was run without any ARIs having been imported previously (we are aware the topics are not recognised):
Screenshot 2024-09-26 093553

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octopus ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 9:24am

@finlay-jisc finlay-jisc marked this pull request as ready for review September 27, 2024 09:22
@finlay-jisc finlay-jisc requested a review from a team as a code owner September 27, 2024 09:22
@finlay-jisc finlay-jisc merged commit e6db70a into main Sep 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants