Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-932: Deploy ARI integration for specific departments #701

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

finlay-jisc
Copy link
Collaborator

Government departments want to display high quality ARIs to ensure they can engage with the research community effectively. I need ministerial sign-off to change existing (outdated) ARIs, so I may take a while to update them. This means on octopus we have to be able to import ARIs from some departments, but not others.

This area being changed (which ARIs are imported) isn't covered in tests so these haven't been run, but it has been tested locally.


Acceptance Criteria:

  • A whitelist exists of government departments that have opted in to the ARI integration
  • For both the initial ingest, and the weekly updates (endpoint), if the department for a given ARI is not on the whitelist, the record is skipped
    • Skipping records does not contribute towards the count of 5 records before stopping the ingest, nor towards the date started/finished matching (i.e. the ingest will not stop due to checking records for depts that have not opted in yet).

Checklist:

  • Local manual testing conducted
  • Automated tests added
  • Documentation updated

@finlay-jisc finlay-jisc requested a review from a team as a code owner October 15, 2024 10:50
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octopus ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 10:50am

@finlay-jisc finlay-jisc merged commit c448f74 into main Oct 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants