Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-927: Convert incremental ARI ingest into a standalone script #728

Merged
merged 11 commits into from
Nov 26, 2024

Conversation

finlay-jisc
Copy link
Collaborator

The purpose of this PR was to facilitate running incremental ARI imports from an ECS service. Until now, it was only triggerable as a lambda function. This allows it to be triggered by running npm run ariImport.

This also brings the incremental and full ARI imports more in line with each other - both can now do dry runs, and both output the same report information (via email if triggered as a lambda, local file otherwise).


Acceptance Criteria:

Incremental ARI imports are runnable as a script.


Checklist:

  • Local manual testing conducted
  • Automated tests added
  • Documentation updated

Tests:

API
Screenshot 2024-11-25 143443

@finlay-jisc finlay-jisc requested a review from a team as a code owner November 25, 2024 14:59
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octopus ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 3:33pm

api/package.json Outdated Show resolved Hide resolved
@finlay-jisc finlay-jisc merged commit 4b2f94c into main Nov 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants