Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-969: Add "Author Types" filter to search #731

Merged
merged 7 commits into from
Dec 5, 2024
Merged

OC-969: Add "Author Types" filter to search #731

merged 7 commits into from
Dec 5, 2024

Conversation

finlay-jisc
Copy link
Collaborator

The purpose of this PR was to allow users to restrict the publication search to display individual vs organisational publications, and to allow PM to differentiate between individual and organisational publications in order to monitor octopus's stats.

This works by:

  • Indexing a boolean field in opensearch tracking whether the publication is authored by a user of type "ORGANISATION"
  • Filter on that when the queryParam is provided to GET /publications

Also done:

  • Use beforeAll instead of beforeEach where appropriate to speed up API tests.
  • Write API tests for GET /publications
  • Fix flaky opensearch seeding test util function
  • Announce search result changes to assistive technologies

Acceptance Criteria:

  • A new filter is present on the publications search about the publication types, titled “Author Types”
    • Below this, two checkboxes are present, unselected by default, of “Individual” and “Organisational”
      • These checkboxes filter by organisational and individual publication authors
      • If both of these checkboxes are deselected, all results are displayed (same behaviour as publication types filter).

Checklist:

  • Local manual testing conducted
  • Automated tests added
  • Documentation updated

Tests:

UI
Screenshot 2024-12-02 111813

API
Screenshot 2024-12-02 112902

E2E
Screenshot 2024-12-02 135243


Screenshots:

Screenshot 2024-12-02 135820

@finlay-jisc finlay-jisc requested a review from a team as a code owner December 2, 2024 14:07
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octopus ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 9:16am

@finlay-jisc finlay-jisc merged commit 8377b09 into main Dec 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants