Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-972: Organisational vs individual author search #732

Merged
merged 19 commits into from
Dec 10, 2024
Merged

OC-972: Organisational vs individual author search #732

merged 19 commits into from
Dec 10, 2024

Conversation

finlay-jisc
Copy link
Collaborator

The purpose of this PR was to provide users with a clear way to differentiate between organisational accounts and individuals in the author search.

N.B. the Science Octopus account change has been done in seed data but needs to be done by hand when this is deployed to int and prod.


Acceptance Criteria:

  • The existing author search excludes all organisational accounts
  • A new type of search is available from the search selection dropdown (alongside Authors, Topics & Publications searches), titled “Organisations”
    • This search is identical to the authors search, except it only displays organisational accounts, and the page is titled “Search Organisations” accordingly
  • Any organisations that have no live publications do not show up in the organisation search results
  • The Science Octopus account is now an organisational account with the name “Octopus”
  • A shared component is used for all common content and results across different search types
  • UI tests are present for this shared component

Checklist:

  • Local manual testing conducted
  • Automated tests added
  • Documentation updated

Tests:

UI
Screenshot 2024-12-05 090536

API
Screenshot 2024-12-05 110938

E2E
Screenshot 2024-12-05 104153


Screenshots:

Screenshot 2024-12-05 111121

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octopus ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 0:09am

ui/package.json Show resolved Hide resolved
ui/src/components/index.tsx Show resolved Hide resolved
ui/tailwind.config.js Show resolved Hide resolved
@finlay-jisc finlay-jisc marked this pull request as ready for review December 5, 2024 11:21
@finlay-jisc finlay-jisc requested a review from a team as a code owner December 5, 2024 11:21
Copy link

@adwearing-jisc adwearing-jisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot to review, reviewed best I could

@finlay-jisc finlay-jisc merged commit 70e9f50 into main Dec 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants